-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v2): restore Algolia search #3828
Conversation
Deploy preview for docusaurus-2 ready! Built with commit 360b535 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3828--docusaurus-2.netlify.app/classic/ |
@slorber since this is a hot fix I am merging right now, but something seems to me like locale is always |
Thanks, fixed it better here: #3829 The currentLocale is not read from the correct place, so your solution will fix the site but it would still lead to a problem. |
ahhh tooo late :D |
Size Change: +19 B (0%) Total Size: 156 kB ℹ️ View Unchanged
|
Oops sorry :) |
Motivation
Fixes #3826
If i18n is not used,
locale
will beundefined
then, so we shouldn't include it in Algolia's facet filters.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)