fix(v2): remove unnecessary backtick in output #3839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The escaped backtick seems to be present for no clear reason. As a matter of fact, it seems to be cluttering the output. So, remove the unnecessary backtick in the output.
|
Deploy preview for docusaurus-2 ready! Built with commit 82ba2c1 |
lex111
suggested changes
Nov 29, 2020
slorber
added
pr: polish
|
thanks, updated Jest the snapshot for you and will merge asap |
|
Great, thanks! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On reading the output that gets printed when there are inexistent IDs, I noticed an additional backtick getting printed after the list of IDs. So, I thought of proposing a change that removes it.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Facing issues with testing the change locally. Hopefully, it should work properly. I'll update once I'm able to test this locally.
Related PRs
N/A