Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): fix PRs not able to add lighthouse/buildsize comment from works #3846

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Nov 30, 2020

Motivation

A PR opened from a fork will trigger CI but the CI workflows can't comment on the original PR, due to security reasons.

This change should fix it.

Refs:
https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
https://github.community/t/github-actions-are-severely-limited-on-prs/18179/19

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 30, 2020
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 30, 2020
@netlify
Copy link

netlify bot commented Nov 30, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 70c835b

https://deploy-preview-3846--docusaurus-2.netlify.app

@slorber slorber merged commit 764d1fd into master Nov 30, 2020
@slorber slorber deleted the slorber/fix-github-actions-CI branch August 17, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants