-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v2): dynamic dark mode detection without toggle widget #3877
Conversation
Hi @hmil! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Please re-run the CLA check. |
Size Change: 0 B Total Size: 157 kB ℹ️ View Unchanged
|
✔️ Deploy preview for docusaurus-2 ready! 🔨 Explore the source changes: 2ffa4df 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fca28993552280007a8671f 😎 Browse the preview: https://deploy-preview-3877--docusaurus-2.netlify.app |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
thanks, that makes sense! |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3877--docusaurus-2.netlify.app/classic/ |
Motivation
Dynamic automatic dark mode detection is disabled when the manual switch is hidden. But I want to enjoy the benefits of automatic dark-mode switching without showing the manual toggle.
See details in #3876
close #3876
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
With the following config:
🎥 before this fix
🎥 after this fix
Not shown in the screencasts: Currently, the correct color theme gets applied but only if you do a hard reload of the page. The difference that this fix makes is that you don't have to reload the page anymore.
Related PRs
none