fix(v2): disables all inlining in CleanCSS #3943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy preview for docusaurus-2 ready! 🔨 Explore the source changes: 96562af 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fdf43faa9b16c000761e84b 😎 Browse the preview: https://deploy-preview-3943--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3943--docusaurus-2.netlify.app/classic/ |
|
Size Change: +8 B (0%) Total Size: 155 kB ℹ️ View Unchanged
|
slorber
reviewed
Dec 21, 2020
| @@ -203,15 +203,15 @@ export function compile(config: Configuration[]): Promise<void> { | |||
| const compiler = webpack(config); | |||
| compiler.run((err, stats) => { | |||
| if (err) { | |||
| reject(err); | |||
| reject(new Error(err.toString())); | |||
There was a problem hiding this comment.
Was wondering, shouldn't we use an early return here?
Or are there cases where we have both an error and stats?
There was a problem hiding this comment.
I don't know, I think we'll leave it as it is for now, during the migration to webpack 5, let's get back to this.
|
Thanks, LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #3942
See clean-css/clean-css#914 and https://github.com/jakubpawlowicz/clean-css#inlining-options for more details.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
See To Reproduce section in #3942 issue.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)