Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix blog only contextual search #3968

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Dec 29, 2020

Motivation

Search feature assumes the docs plugin is available, which is not always the case.

This is a quickfix so that the Algolia search can be used in blog-only mode without any problem.
(better solution to be found)

Fixes #3947

Test Plan

blog only preview with search can build

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 29, 2020
@slorber slorber requested a review from lex111 as a code owner December 29, 2020 14:50
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 29, 2020
@netlify
Copy link

netlify bot commented Dec 29, 2020

✔️ Deploy preview for docusaurus-2 ready!

🔨 Explore the source changes: 7ec48b9

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5feb422006f8e2000750636c

😎 Browse the preview: https://deploy-preview-3968--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 88
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3968--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

Size Change: +10 B (0%)

Total Size: 155 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB +1 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.82 kB +1 B (0%)
website/build/main.********.js 111 kB +8 B (0%)
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@slorber slorber merged commit 9fdac1a into master Dec 29, 2020
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/fix-blog-only-contextual-search branch August 17, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use algolia integration
3 participants