-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): Add Datagit site to showcase page #3997
Conversation
- add datagit.png to showcase
✔️ Deploy preview for docusaurus-2 ready! 🔨 Explore the source changes: 3762997 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5ff3d2162dec0600072284b2 😎 Browse the preview: https://deploy-preview-3997--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3997--docusaurus-2.netlify.app/classic/ |
Size Change: +11 B (0%) Total Size: 154 kB ℹ️ View Unchanged
|
thanks @massoudmaboudi that's a great example. Can you please document what you had to do to add i18n support? |
merging as the failing test is already fixed on master |
btw @massoudmaboudi your site repo does not exist or is not public, can you please fix the URL? We only showcase open-source websites |
@slorber Thank you for merging the changes. I should mention that I didn't use i18n. |
@slorber May I ask you to provide the details about the error? Because even now I cloned from master and still I have the error with me. I have a clean code from master. Thanks |
The repo is private. I will make it public. |
@massoudmaboudi the error is due to a test that only works for the 2020 year, it broke with the new year. It has been fixed already. If you already have a fork, to have to update your fork's master based on docusaurus master to make it up to date. |
Thanks for making your repo public. The only thing you need for RTL support was in this CSS file? or are there other places? https://github.com/massoudmaboudi/datagit_v2.docusaurus/blob/master/src/css/custom.css I see many swizzled components, is this for RTL support? We'll make sure you don't need to swizzle so much components to add RTL support very soon |
I added some CSS changes to ./src/css/custom.css and inside the swizzled components, I added some CSS changes + some changes in the text. For example the next and previous article button inside the blog and document. The text is not English so I changed them inside the swizzed components. IDK it is possible or not, but same like versioning, if we can add this functionality that by changing the language to an RTL language, the CSS and the texts for different parts of the website can change dynamically, it would be really great. Also, there is another way that the website can support multiple instances inside itself. The reason behind it is that translation doesn't work properly for many languages and Persian is not an exception too. So, it means I have to write the content for the blog and docs manually. For sure, the layout components should be different then. It is like we are embedding 2 websites inside each other. |
About the labels such as Next/Previous etc, they will be editable thanks to the i18n feature as well (some labels remain to be supported currently, but the goal is to cover all of them in the end). You will also be able to say "this locale is RTL" and the theme should support it well, will work on that soon (including support a way when Persian is your default locale and you don't plan to add other locales).
This is actually how the i18n system will work somehow (see http://jest-v2.netlify.app/ja), it's just we don't support RTL yet in the theme, but we will.
Not sure to understand 😅 |
@slorber What I meant by
is that, I don't like to use translation systems or services. I like to rewrite my content in different languages myself. I hope I clarified it. |
Motivation
The RTL documentation of Datagit.ir is using Docusaurus v2. It could be cool to add it to the showcase page as it uses an RTL context and it is the first RTL website up and running using this platform.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run yarn run start:v2 and check that the page http://localhost:3000/showcase is rendered properly.
Related PRs
No