Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): Switch from inquirer to prompts #4091

Merged
merged 1 commit into from
Jan 27, 2021
Merged

refactor(v2): Switch from inquirer to prompts #4091

merged 1 commit into from
Jan 27, 2021

Conversation

RDIL
Copy link
Contributor

@RDIL RDIL commented Jan 22, 2021

Signed-off-by: Reece Dunham [email protected]

Motivation

Continuation of previous PR

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

It works the same, I tried it on the v2 site

Related PRs

my last one

@RDIL RDIL requested review from lex111 and slorber as code owners January 22, 2021 17:41
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 22, 2021
@netlify
Copy link

netlify bot commented Jan 22, 2021

@netlify
Copy link

netlify bot commented Jan 22, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit c91dc05

https://deploy-preview-4091--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 89
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4091--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

Size Change: 0 B

Total Size: 27.1 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.9 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.02 kB 0 B

compressed-size-action

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jan 27, 2021
@slorber
Copy link
Collaborator

slorber commented Jan 27, 2021

Thanks 🙏

For ref, previous PR: #4012

@slorber slorber merged commit 95f81d2 into facebook:master Jan 27, 2021
@RDIL RDIL deleted the prompts branch January 27, 2021 16:25
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants