feat(v2): improve templates, use JSDoc type annotation, improve docusaurus.config.js autocompletion
#4098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 04143d1 https://app.netlify.com/sites/docusaurus-1/deploys/600f689ae11f810007723c1b |
|
Size Change: +3 B (0%) Total Size: 28.8 kB ℹ️ View Unchanged
|
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 04143d1 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4098--docusaurus-2.netlify.app/classic/ |
|
Please also add it to the templates, located here. |
|
@RDIL okay! |
RDIL
approved these changes
Jan 26, 2021
|
thanks, that looks like a convenient improvement without forcing users to adopt TypeScript 👍 |
slorber
changed the title
docusaurus.config.js using jsdocdocusaurus.config.js autocompletion
This was referenced Mar 10, 2021
Closed
Closed
Closed
Closed
This was referenced Mar 12, 2021
Merged
Merged
Closed
slorber
pushed a commit
that referenced
this pull request
Jul 22, 2021
…saurus.config.js` autocompletion (#4098) Co-authored-by: LittleboyHarry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Better type hints and smart complement for
docusaurus.config.jsusing jsdoc.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Worked nice in vscode!
2021-01-24_21-55-50.mp4
Related PRs
NONE