fix(v2): BaseUrl issue banner insertion should be prevented if JS can load #4155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[V1] Deploy preview success Built with commit c8a4f7d |
|
Size Change: +2 B (0%) Total Size: 28.8 kB ℹ️ View Unchanged
|
|
Deploy preview for docusaurus-2 ready! Built with commit c8a4f7d |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4155--docusaurus-2.netlify.app/classic/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up of:
#4125
#4136
Change BaseUrl issue banner integration so that it's not indexed by SEO.
Instead of trying to insert it, and then remove it, we now prevent it from being inserted in the first place for the optimistic case (React can hydrate successfully).
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
SEO tools