Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update command to check yarn installation #4170

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

jlin27
Copy link
Contributor

@jlin27 jlin27 commented Feb 3, 2021

As listed yarn version works but throws an error. This PR updates the command that checks the install to be yarn --version per the Yarn docs

As listed `yarn version` doesn't work. According to [Yarn docs](https://classic.yarnpkg.com/en/docs/install#mac-stable), the command to check install should be `yarn --version`.
@jlin27 jlin27 requested review from lex111 and slorber as code owners February 3, 2021 19:48
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 3, 2021
@jlin27 jlin27 changed the title Update check yarn installation command Update command to check yarn installation Feb 3, 2021
@netlify
Copy link

netlify bot commented Feb 3, 2021

@netlify
Copy link

netlify bot commented Feb 3, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 38caff3

https://deploy-preview-4170--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 3, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 60
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4170--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

github-actions bot commented Feb 3, 2021

Size Change: 0 B

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.7 kB 0 B
website/build/assets/js/main.********.js 109 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB 0 B

compressed-size-action

@lex111 lex111 merged commit 4d3573d into facebook:master Feb 3, 2021
@lex111
Copy link
Contributor

lex111 commented Feb 3, 2021

@jlin27 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants