-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): improve cli docs #4259
Conversation
[V1] Deploy preview success Built with commit 94fc7aa |
Deploy preview for docusaurus-2 ready! Built with commit 94fc7aa |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4259--docusaurus-2.netlify.app/classic/ |
Size Change: 0 B Total Size: 543 kB ℹ️ View Unchanged
|
I added |
I added the blog reference part while compiling, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, will just add the npm2yarn tabs everywhere :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@massoudmaboudi please make smaller pull requests instead of one big that do multiple things.
I'm willing to merge:
- the fa translation file
- the CLI-related doc changes
But I'm not really willing to merge the "referencing blog posts" doc.
If you made 3 separate PRs I would have been able to merge 2 of the 3 ;)
Extracted the fa translations to #4271 Will clean up the current PR from the "referencing" section and merge it, but feel free to resubmit it if you feel we should add more doc, but to me, this has nothing to do with the markdown features, it's just a regular link. Here's a "backup" of your doc in case you find this useful: Referencing blog postsIf you want to reference a blog post file, you could use the name of the post you want to reference. For example, if you are in ---
title: Hello There
--- You can add a slug to a blog post in its metadata. Consider another blog post named ---
title: Bye Everyone
slug: bye-everyone
--- I am referencing a blog post in Reference to another blog post with a slug in :::caution Be careful that we should convert the address of the blog post without slug from:
|
@slorber |
I don't think it's a good idea, it's just a regular link nothing else. If we were to add this kind of doc, it couldn't be related to "markdown features" nor the blog, but be more generic, because it's just a link, and the link in md or in blog posts or in page is the same concept under the hood |
Motivation
This part was missing in the documents and it is kinda useful to have this kinda referencing.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run yarn run start:v2 and check that the page http://localhost:3000/ is rendered properly.
Related PRs
No