-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polish(v2): Add more tags translations #4275
Conversation
@@ -10,7 +10,9 @@ | |||
"theme.blog.post.paginator.newerPost": "Следующий пост", | |||
"theme.blog.post.paginator.olderPost": "Предыдущий пост", | |||
"theme.blog.post.readMore": "Читать дальше", | |||
"theme.blog.tags": "Теги:", | |||
"theme.tags.tagsPageLink": "Просмотреть все теги", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lex111 going to merge now but feel free to edit if google translate failed for this string ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :)
[V1] Deploy preview success Built with commit a7cd896 |
Size Change: 0 B Total Size: 544 kB ℹ️ View Unchanged
|
Deploy preview for docusaurus-2 ready! Built with commit a7cd896 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4275--docusaurus-2.netlify.app/classic/ |
"theme.blog.tags": "Tags:", | ||
"theme.tags.tagsPageLink": "View All Tags", | ||
"theme.tags.tagsPageTitle": "Tags", | ||
"theme.tags.tagsListLabel": "Tags:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like duplicate to me, colon should not be a apart of translation string which will allow to reuse the 18n string.
Will have to check but afaik punctuation should be left to translators and
not hard-coded.
I think some languages add a space or not before
For RTL the : is on the other side
Le mer. 24 févr. 2021 à 19:36, Bartosz Kaszubowski <[email protected]>
a écrit :
… ***@***.**** commented on this pull request.
------------------------------
In packages/docusaurus-theme-classic/codeTranslations/base.json
<#4275 (comment)>:
> @@ -10,7 +10,9 @@
"theme.blog.post.paginator.newerPost": "Newer Post",
"theme.blog.post.paginator.olderPost": "Older Post",
"theme.blog.post.readMore": "Read More",
- "theme.blog.tags": "Tags:",
+ "theme.tags.tagsPageLink": "View All Tags",
+ "theme.tags.tagsPageTitle": "Tags",
+ "theme.tags.tagsListLabel": "Tags:",
Looks like duplicate to me, colon should not be a apart of translation
string which will allow to reuse the 18n string.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#4275 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW6PWPYYFUJVXW2MIT4ZTTAVBMTANCNFSM4YCUIXHQ>
.
|
@slorber In my opinion that's the reason why colon should be separated (and placed in the separate node/tag), so the RTL conversion handle most of changes like that automatically for the users. 🙂 But to be honest I have only the experience with maintain the EU only multilingual sites, so I have not much RTL experience. |
Motivation
As part of the first Docusaurus LTR / Farsi site here: https://github.com/massoudmaboudi/datagit_v2.docusaurus/pull/5
I noted that some tags related translations were missing, so let's add them.
Using the
theme.tags
namespace because we'll reuse it for doc tags later