-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): add ocpeasy to users #4331
Conversation
Hi @dbrrt! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
[V1] Deploy preview failure Built without sensitive environment variables with commit ff16d7c https://app.netlify.com/sites/docusaurus-1/deploys/603f45fe5262240008fc68fc |
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit ff16d7c |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4331--docusaurus-2.netlify.app/classic/ |
Size Change: 0 B Total Size: 532 kB ℹ️ View Unchanged
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :)
preview: require('./showcase/ocpeasy.png'), | ||
website: 'https://www.ocpeasy.org', | ||
source: 'https://github.com/ocpeasy/website', | ||
tags: ['design'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tags: ['design'], | |
tags: [], |
removing this as it's reserved for sites having a custom design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not able to commit to your PR so please accept my suggestion so that I can merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to merge and fix this in another pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slorber Just saw your message, thanks for that!
Motivation
Adding ocpeasy project to the showcase/users section.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Starting the website should display OCPeasy in the showcase part, including
ocpeasy.png
preview.Related PRs
N/A