refactor(v2): add ExecutionEnvironment, BrowserOnly, isInternalUrl to type aliases #4387
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[V1] Deploy preview failure Built without sensitive environment variables with commit b783178 https://app.netlify.com/sites/docusaurus-1/deploys/6049546f27c2c500078442be |
armano2
changed the title
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit b783178 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4387--docusaurus-2.netlify.app/classic/ |
slorber
added
the
pr: polish
slorber
changed the title
|
👍 |
This was referenced Mar 17, 2021
Closed
Closed
Closed
Merged
This was referenced Mar 17, 2021
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
add missing
ExecutionEnvironment,BrowserOnly,isInternalUrlto known type aliasesHave you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
if it compiles its working
Related tickets
ref; #3424