Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unstable yarn.lock #5067

Merged
merged 2 commits into from
Jun 25, 2021
Merged

chore: unstable yarn.lock #5067

merged 2 commits into from
Jun 25, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jun 25, 2021

CI does not catch unstable lockfile errors

Yarn v1 --frozen-lockfile is not strictly equivalent to Yarn v2 --immutable (it does not throw)

So move back to git diff --exit-code to detect a modified lockfile in CI

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jun 25, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 25, 2021
@netlify
Copy link

netlify bot commented Jun 25, 2021

✔️ [V2]

🔨 Explore the source changes: 2fb611e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60d5e463815ce60007cf4a91

😎 Browse the preview: https://deploy-preview-5067--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 25, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 68
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5067--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Jun 25, 2021

Size Change: 0 B

Total Size: 601 kB

ℹ️ View Unchanged
Filename Size
website/build/assets/css/styles.********.css 87.7 kB
website/build/assets/js/main.********.js 415 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 66.5 kB
website/build/docs/introduction/index.html 235 B
website/build/index.html 31.3 kB

compressed-size-action

@slorber slorber requested a review from lex111 as a code owner June 25, 2021 14:12
@slorber slorber merged commit 4d93c89 into master Jun 25, 2021
@slorber slorber deleted the slorber/fix-lockfile branch August 17, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants