Regenerate blog metadata on request to blog #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelMarcey
approved these changes
Apr 21, 2018
There was a problem hiding this comment.
@yangshun Hi! I think this is a good fix for now - better than broken.
When we implement something like Hot Reload, we can think about it being more efficient. In general, server.js is used for local testing, not live production, so not optimal efficiency could be ok for a bit, imho.
I will let you merge.
|
@yangshun Unrelated, there is a branch called |
|
I don't think that branch was created by me. I don't have push permissions to the repo.
…On Sat, Apr 21, 2018, 7:40 AM Joel Marcey ***@***.***> wrote:
@yangshun <https://github.com/yangshun> Unrelated, there is a branch
called fix-nav at https://github.com/facebook/Docusaurus/branches. Do you
need it any longer?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#590 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQRHTIXRvimU5LEI7iTOyWrQrQGaKe-ks5tq0T4gaJpZM4TeUcy>
.
|
|
Sorry the branch was indeed created by me. It's weird how that happened because I don't have push permissions. Anyway I don't need it anymore and thanks for deleting it! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #237. I'm not entirely sure if this is the best fix as it can be quite an expensive operation if there are many blog posts. IMO a better way would be to watch the blog files and only regenerate when it changes, but both ways has it pros and cons. Feel free to close this if you prefer the file watching method.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Related PRs
NA