-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ideal-image): allow translating status messages #6173
Conversation
✔️ [V2] 🔨 Explore the source changes: 49ec999 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61cb03a74b98f000086938e2 😎 Browse the preview: https://deploy-preview-6173--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6173--docusaurus-2.netlify.app/ |
Size Change: 0 B Total Size: 667 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
probably not too interesting to invest a lot of time on this component, someday we'll probably have to rewrite it from scratch
Oh well, that's not something I had a plan for... Maybe we do need to change the Webpack setup so other image loaders work with this, but the component can probably stay |
Motivation
#4542
Have you read the Contributing Guidelines on pull requests?
Yes