Fix undefined variable error when adding custom page #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-preview ready! Built with commit 60a9ec1 |
`'en'` is written as `en`
JoelMarcey
approved these changes
May 19, 2018
|
I'm working on a PR for #413, so I had to read all the relevant codes 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I tried to add a custom page to Docosaurus
Build the static files
But got an error
en is not definedThis is because of a typo
https://github.com/facebook/Docusaurus/blob/b66045f28478e05a7de701bb644412c1898fc0af/lib/server/generate.js#L533
It should be
writeFileAndCreateFolder(targetFile.replace(sep + 'en' + sep, sep), str);Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run test in root folder
Related PRs
#490