Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docusaurus versions page to links to correct language #740

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

endiliey
Copy link
Contributor

@endiliey endiliey commented Jun 8, 2018

Motivation

Current versions page always point to english docs despite being in another language.
Check https://docusaurus.io/ro/versions.html links and you'll see that links points to /en/

wrong

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

http://localhost:3000/ro/versions.html links point to /ro/ docs
ro

http://localhost:3000/en/versions.html links point to /en/ docs
en

@endiliey endiliey changed the title Fix versions page to point to correct language Fix Docusaurus versions page to links to correct language Jun 8, 2018
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 7b3f5ee

https://deploy-preview-740--docusaurus-preview.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 8, 2018
Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JoelMarcey JoelMarcey merged commit c000aca into facebook:master Jun 8, 2018
@endiliey endiliey deleted the versions branch June 29, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants