Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --no-minify flag to docusaurus start #7452

Merged
merged 2 commits into from
May 20, 2022
Merged

feat: add --no-minify flag to docusaurus start #7452

merged 2 commits into from
May 20, 2022

Conversation

lanegoolsby
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

This adds the ability to pass the --no-minify flag to start like we can for build. This will allow us to put breakpoints in the browser dev tools and therefore make debugging custom components much easier.

Test Plan

Verified that the app still starts without the flag
Verified that the app starts with the flag enabled

Test links

https://stackoverflow.com/questions/71832418/disable-minification-in-docusaurus

@facebook-github-bot
Copy link
Contributor

Hi @lanegoolsby!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented May 19, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 50a119e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6286b6c440b66700086ca9bf
😎 Deploy Preview https://deploy-preview-7452--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 91 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 80 🟢 99 🟢 100 🟢 100 🟢 90 Report

@netlify
Copy link

netlify bot commented May 19, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit be01571
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6286b7cd6df7280008df7e54
😎 Deploy Preview https://deploy-preview-7452--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 19, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Josh-Cena Josh-Cena changed the title feat: Adding --no-minify flag to start feat: add --no-minify flag to docusaurus start May 20, 2022
@Josh-Cena Josh-Cena added the pr: new feature This PR adds a new API or behavior. label May 20, 2022
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense. Thanks!

@Josh-Cena Josh-Cena merged commit 5aaa33f into facebook:main May 20, 2022
@lanegoolsby lanegoolsby deleted the no-minify-on-serve branch May 20, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants