Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix a lot of errors in type-aware linting #7477

Merged
merged 1 commit into from
May 24, 2022
Merged

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Enabled type-aware linting locally, fixed a lot of warnings/errors.

All of these seem pretty harmless. I've deferred the more involved ones to future. This is also why I haven't enabled it in CI yet.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label May 24, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 24, 2022 07:09
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 24, 2022
@netlify
Copy link

netlify bot commented May 24, 2022

[V2]

Name Link
🔨 Latest commit f6398c7
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/628c8764e178c30008a49e7a
😎 Deploy Preview https://deploy-preview-7477--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 24, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 86 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 86 🟢 99 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented May 24, 2022

Size Change: +3 B (0%)

Total Size: 796 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 52.3 kB 0 B
website/build/assets/css/styles.********.css 106 kB 0 B
website/build/assets/js/main.********.js 599 kB +3 B (0%)
website/build/index.html 38.9 kB 0 B

compressed-size-action

@Josh-Cena Josh-Cena merged commit bf1513a into main May 24, 2022
@Josh-Cena Josh-Cena deleted the jc/fix-lint branch May 24, 2022 07:40
@Josh-Cena Josh-Cena added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. and removed pr: polish This PR adds a very minor behavior improvement that users will enjoy. labels May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants