Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing triple``` characters in markdown-features.mdx #9694

Closed
wants to merge 1 commit into from
Closed

Fix missing triple``` characters in markdown-features.mdx #9694

wants to merge 1 commit into from

Conversation

heysokam
Copy link
Contributor

@heysokam heysokam commented Jan 3, 2024

Sorry to be blunt, but I'm not gonna spend +1-2h reading the PR rules just to send such a simple fix.
I'm just fixing missing ``` characters.
Take it or leave it. I don't care either way.

Feel free to fix this in the proper way in a different PR or something, and remove/close this one, if the rules are strict enough for this to not be allowed at all.

Erroring output, without ```
image

Expected output, with ```
image

@heysokam heysokam requested a review from slorber as a code owner January 3, 2024 16:43
@facebook-github-bot
Copy link
Contributor

Hi @heysokam!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Jan 3, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 3feecc2
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65958ec2eb577600087509dd
😎 Deploy Preview https://deploy-preview-9694--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 3, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 60 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 82 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟢 93 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 73 🟢 100 🟢 100 🟢 90 🟠 89 Report

@slorber
Copy link
Collaborator

slorber commented Jan 4, 2024

thanks for reporting the problem

However it's technically impossible for me to merge if you don't sign the CLA, so let me know if you want to proceed. Otherwise I'll open another pr myself.

@slorber
Copy link
Collaborator

slorber commented Jan 4, 2024

Going to open another pr based on yours because cla is not signed and I have other tiny edits to the template to make

BTW using indentation doesn't work anymore for code blocks, cf the result of your PR still not looking great:

CleanShot 2024-01-04 at 13 19 18@2x

@slorber
Copy link
Collaborator

slorber commented Jan 4, 2024

will be fixed in #9696 and you'll be credited

@slorber slorber closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants