-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix typo in script command of typescript-support.mdx #9761
Conversation
Hi @brightzoe! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Yes, you're right about the behavior of npm run and yarn run; that was my oversight. But I'm useing pnpm. As for pnpm, after further testing, I can confirm that it behaves like yarn: there's no need for an extra -- to pass additional arguments. Just place the arguments directly after the command. References: pnpm run docs On inspecting the code, I traced the issue back to a third-party package The specific problem seems to be located in the path https://github.com/facebook/docusaurus/blob/main/packages/docusaurus-remark-plugin-npm2yarn/src/index.ts, related to the so the issue is with npm-to-yarn ,not the a typo in docusaurus. This pr should be closed. |
this change is present in yarn but has not been added to pnpm, i missed that when i added support for it in nebrelbug/npm-to-yarn#37 |
Thanks I created the npm-to-yarn bug report, let me know if anyone wants to contribute a fix: |
Pre-flight checklist
Motivation
Test Plan
This is not a code change,only fix typo.
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs