Fatal Exception: java.lang.SecurityException !@Too many alarms (500)

[vhontar]

Goals

I want to avoid background crashes which happened to the users all the time.

Expected Results

https://github.com/facebook/facebook-android-sdk/blob/5.x-branch/facebook-core/src/main/java/com/facebook/AccessTokenManager.java#L157

Could you please at least put alarm set to try/catch to avoid crashes in the background

try {
alarmManager.set(
                AlarmManager.RTC,
                accessToken.getExpires().getTime(),
                alarmIntent);
} catch (SecurityException e) {}

Actual Results

Fatal Exception: java.lang.SecurityException
!@Too many alarms (500) registered from uid 10126
android.os.Parcel.createException (Parcel.java:1966)
android.app.AlarmManager.set (AlarmManager.java:379)
com.facebook.AccessTokenManager.setTokenExpirationBroadcastAlarm (AccessTokenManager.java:172)
com.facebook.AccessTokenManager.setCurrentAccessToken (AccessTokenManager.java:135)
com.facebook.AccessTokenManager.setCurrentAccessToken (AccessTokenManager.java:115)
com.facebook.AccessTokenManager$4.onBatchCompleted (AccessTokenManager.java:364)
com.facebook.GraphRequest$5.run (GraphRequest.java:1400)
android.os.Handler.handleCallback (Handler.java:873)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:965)

Steps to Reproduce

If you've set up already more than 500 alarms by the app. Some devices, especially Samsung (android 7) has some security measures to forbid to create more than 500 alarms.

Is it possible to add this try/catch code to avoid such crashes in the future?

[emreyanik]

In addition to this, could you change pending intent flag to PendingIntent.FLAG_UPDATE_CURRENT from 0 to prevent alarm duplication on some Samsung devices.

https://github.com/facebook/facebook-android-sdk/blob/5.x-branch/facebook-core/src/main/java/com/facebook/AccessTokenManager.java#L170

Expected Result

PendingIntent alarmIntent = PendingIntent.getBroadcast(context, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT);

[vhontar]

The problem is that I have to set alarms for different local notifications for different times. So request code is different for all pending intents. That's why they are all different. If I understand right FLAG_UPDATE_CURRENT doesn't help in that case if only request code isn't the same

 private fun cancelAlarm(myBookingNotification: MyBookingNotification) {
        val notificationIntent = getNotificationIntent(myBookingNotification)
        val pendingIntent = PendingIntent.getBroadcast(context, myBookingNotification.uniqueNotificationId, notificationIntent, PendingIntent.FLAG_UPDATE_CURRENT)
        val alarmManager = context.getSystemService(Context.ALARM_SERVICE) as AlarmManager
        if (pendingIntent != null) {
            alarmManager.cancel(pendingIntent)
        }
    }

private fun schedulerAlarm(myBookingNotification: MyBookingNotification) {
        val notificationIntent = getNotificationIntent(myBookingNotification)
        val pendingIntent = PendingIntent.getBroadcast(context, myBookingNotification.uniqueNotificationId, notificationIntent, PendingIntent.FLAG_UPDATE_CURRENT)

        val futureInMillis = System.currentTimeMillis() + delay
        val alarmManager = context.getSystemService(Context.ALARM_SERVICE) as AlarmManager
        try {
            alarmManager.set(AlarmManager.RTC_WAKEUP, futureInMillis, pendingIntent)
        } catch (e: SecurityException) { }
}

[emreyanik]

I think there is a misunderstanding. You're right about alarms with different request code doesn't need FLAG_UPDATE_CURRENT. But my suggestion was for facebook sdk, not for you. Because facebook set same alarm with same request code so some samsung devices throw exception when exceeds the alarm limit. Actually I increased your suggestion :)

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

[vhontar]

Hi, you can close the issue, thank you!

…

On Wed, 19 Feb 2020 at 12:43, stale[bot] ***@***.***> wrote: Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#627?email_source=notifications&email_token=AC4LEEFB73XQPKYFLNM6FR3RDUEOBA5CNFSM4JNNQVBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMHI2UY#issuecomment-588156243>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC4LEEC363K6CJOPJN2N6ELRDUEOBANCNFSM4JNNQVBA> .

[iceteahh]

@vhontar What is the solution for it? I'm facing this problem too

[ryutb]

@vhontar What is the solution for it? I'm facing this problem too

Me too