Initialize fan_service config member in hwtest

Summary: This was masking Janga/Tahan fan service issues. I verified no other NPIs were impacted. Reviewed By: alandau Differential Revision: D67762321 fbshipit-source-id: 704047537e08f3a3c47bc3cee0e80921c5da62ac
facebook · Jan 6, 2025 · 2bb9a45 · 2bb9a45
1 parent fafe1ab
commit 2bb9a45
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/fboss/platform/fan_service/ControlLogic.cpp b/fboss/platform/fan_service/ControlLogic.cpp
@@ -468,7 +468,7 @@ void ControlLogic::programLed(const Fan& fan, bool fanFailed) {
         (fanFailed ? "Fail" : "Good"),
         valueToWrite);
   } else {
-    XLOG(DBG1) << fmt::format(
+    XLOG(INFO) << fmt::format(
         "{}: FAN LED sysfs path is empty. It's likely that FAN LED is controlled by hardware.",
         *fan.fanName());
   }

diff --git a/fboss/platform/fan_service/hw_test/FanServiceHwTest.cpp b/fboss/platform/fan_service/hw_test/FanServiceHwTest.cpp
@@ -28,14 +28,14 @@ class FanServiceHwTest : public ::testing::Test {
  public:
   void SetUp() override {
     std::string fanServiceConfJson = ConfigLib().getFanServiceConfig();
-    auto config =
+    fanServiceConfig_ =
         apache::thrift::SimpleJSONSerializer::deserialize<FanServiceConfig>(
             fanServiceConfJson);
-    XLOG(INFO) << apache::thrift::SimpleJSONSerializer::serialize<std::string>(
-        config);
-    auto pBsp = std::make_shared<Bsp>(config);
+    auto pBsp = std::make_shared<Bsp>(fanServiceConfig_);
     EXPECT_NO_THROW(
-        controlLogic_ = std::make_unique<ControlLogic>(config, pBsp));
+        controlLogic_ =
+            std::make_unique<ControlLogic>(fanServiceConfig_, pBsp));
+    EXPECT_FALSE(fanServiceConfig_.fans()->empty());
   }
 
   std::unique_ptr<ControlLogic> controlLogic_;