set trap priority only if packet action is trap or copy

Summary:
as titled

this is as per SAI spec

Reviewed By: msomasundaran

Differential Revision:
D67953991

Privacy Context Container: L1125642

fbshipit-source-id: a8f6c79574a4b2fa4967f5a5c74e06932ae238b5

fboss/agent/hw/sai/switch/SaiHostifManager.cpp

@@ -167,8 +167,13 @@ SaiHostifManager::makeHostifTrapAttributes(
   SaiHostifTrapTraits::Attributes::PacketAction packetAction{
       hostifPacketAction};
   SaiHostifTrapTraits::Attributes::TrapType trapType{hostifTrapId};
-  SaiHostifTrapTraits::Attributes::TrapPriority trapPriority{priority};
-  SaiHostifTrapTraits::Attributes::TrapGroup trapGroup{trapGroupId};
+  std::optional<SaiHostifTrapTraits::Attributes::TrapPriority> trapPriority{};
+  std::optional<SaiHostifTrapTraits::Attributes::TrapGroup> trapGroup{};
+  if (hostifPacketAction == SAI_PACKET_ACTION_TRAP ||
+      hostifPacketAction == SAI_PACKET_ACTION_COPY) {
+    trapPriority = priority;
+    trapGroup = SaiHostifTrapTraits::Attributes::TrapGroup(trapGroupId);
+  }
   return SaiHostifTrapTraits::CreateAttributes{
       trapType, packetAction, trapPriority, trapGroup};
 }