Fix all build.gradle files to use new deps declarations #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oprisnik
requested changes
Dec 13, 2017
imagepipeline-base-test/build.gradle
Outdated
| @@ -36,7 +37,7 @@ task jarTest (type: Jar) { | |||
| } | |||
|
|
|||
| configurations { | |||
| testOutput.extendsFrom (testCompile) | |||
| testOutput.extendsFrom (testimplementation) | |||
There was a problem hiding this comment.
Don't you want testImplementation?
imagepipeline-base/build.gradle
Outdated
| testCompile("org.powermock:powermock-api-mockito:${POWERMOCK_VERSION}") { | ||
| implementation "com.parse.bolts:bolts-tasks:${BOLTS_ANDROID_VERSION}" | ||
| implementation project(':fbcore') | ||
| implementation 'com.facebook.soloader:soloader:0.1.0' |
There was a problem hiding this comment.
can you also do the same versioning as we do for the others? Also, should this be in this diff?
foghina
force-pushed
the
fix-gradle-files
branch
from
5a9178e to
523d0fc
Compare
|
@foghina has updated the pull request. |
|
Whoops, some of the changes from #1989 butted their way in here. Removed them and fixed the |
facebook-github-bot
approved these changes
Dec 13, 2017
There was a problem hiding this comment.
@oprisnik is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zjupure
pushed a commit
to zjupure/fresco
that referenced
this pull request
Jan 1, 2018
Summary: We were getting a lot of deprecation warnings when building with gradle after the update to 4.1. This PR switches all `provided` to `compileOnly` and `compile` to `implementation` / `api`, depending on the use case. CI + run showcase app. Closes facebook#1990 Reviewed By: oprisnik Differential Revision: D6556102 Pulled By: foghina fbshipit-source-id: 2b44efa74d379cc00192466a0ab31b2faeb9402a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation (required)
We were getting a lot of deprecation warnings when building with gradle after the update to 4.1. This PR switches all
providedtocompileOnlyandcompiletoimplementation/api, depending on the use case.Test Plan (required)
CI + run showcase app.