Parse Member and TypeCast expressions in super class types

[xleoooo]

Summary

Previously, member expressions in parent classes like class A extends Foo.Bar, and type casts such as class A extends (Foo: Bar), were not parseable by flow-api-translator. This change adds support.

Test Plan

Previously unparseable files in react-native are now parseable

[facebook-github-bot]

Hi @xleoooo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[pieterv]

In addition to the inline comments please add test cases.

I'm also curious what you are using this tool chain for?

[xleoooo]

Still working on those test cases, I'm having some trouble with jest, but was hoping to get a review on the source changes in the meantime.

FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory

[huntie]

LGTM, with nits to action. cc @pieterv

I've run this against the existing test suite (with jest --watch) and the affected tests all pass. Just to check: @xleoooo you've observed this produces an end-to-end fix?

[xleoooo]

Just to check: @xleoooo you've observed this produces an end-to-end fix?

yes, with some small caveat: some of the current RN source isn't valid input.

class FileReader extends (EventTarget(...READER_EVENTS): any) {}

AFAIK this is valid flow source code, but neither of the following typedefs are OK based on flow playground

declare class FileReader extends any {}
declare class FileReader extends (EventTarget(...READER_EVENTS): any) {}

So, for type cast super classes, they are only valid for flowToFlowDef if cast to Identifier. This means we'll still need to add our own typings for EventTarget, instead of casting any.

Feedback actioned

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@xleoooo has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@xleoooo has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@huntie merged this pull request in 14d3201.