Report an error in Execute on tvOS #1530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64090934 |
|
This pull request was exported from Phabricator. Differential Revision: D64090934 |
neildhar
added a commit
to neildhar/hermes
that referenced
this pull request
Oct 9, 2024
Summary: Pull Request resolved: facebook#1530 The body of `Execute` is currently ifdef'd out on tvOS, which includes the return statement. Instead, return false and report an error when it is called on tvOS. Differential Revision: D64090934
neildhar
force-pushed
the
export-D64090934
branch
from
3e84a3b to
7f00a7c
Compare
…oad the correct commit data. Differential Revision: D64030986
Summary: Instead of defining the OS preprocessor flags ourselves in CMake, import TargetConditionals.h which will define them. Differential Revision: D64090935
Summary: Fix up some comments and remove unnecessary ifdefs in ICU, since we never use ICU on Apple platforms. Differential Revision: D64090933
Summary: Pull Request resolved: facebook#1530 The body of `Execute` is currently ifdef'd out on tvOS, which includes the return statement. Instead, return false and report an error when it is called on tvOS. Reviewed By: tmikov Differential Revision: D64090934
|
This pull request was exported from Phabricator. Differential Revision: D64090934 |
neildhar
force-pushed
the
export-D64090934
branch
from
7f00a7c to
cdc06dd
Compare
|
This pull request has been merged in 0ff6c2a. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Summary: Original Author: [email protected] Original Git: 0ff6c2a Original Reviewed By: tmikov Original Revision: D64090934 Pull Request resolved: #1530 The body of `Execute` is currently ifdef'd out on tvOS, which includes the return statement. Instead, return false and report an error when it is called on tvOS. Reviewed By: neildhar Differential Revision: D64362587 fbshipit-source-id: 3bbc29911a5bcf765c23ac4a3d57f9342da71bf1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The body of
Executeis currently ifdef'd out on tvOS, which includesthe return statement. Instead, return false and report an error when it
is called on tvOS.
Differential Revision: D64090934