Remove register stack size override in hermes.cpp #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We are currently overriding any specified register stack size with a size that is fairly low. This was added to allow the register stack to be placed on a thread stack when StackRuntime is enabled, however, it seems like that functionality was removed some time ago, so this limit no longer serves a purpose. Remove it so that sizes set through RuntimeConfig are actually honoured. Set the default RuntimeConfig value to be roughly what the old limit was (no need to suddenly increase the stack size if we haven't had problems yet). Keeping the limit low helps us retain the ability to place the register stack in StackRuntime again in the future. Reviewed By: mhorowitz Differential Revision: D42610775 fbshipit-source-id: 94db4e3eb1d6365749a6db8adfe73a5d298f127c
Summary: As discussed in facebook#135, the default stack size doesn't work for all use cases. In particular, when very large and complex bundles are loaded in dev mode. This PR bumps the default stack size from `64*1024` (512kB) to `128*1024` (1MB). As suggested by tmikov in this comment - facebook#135 (comment). Pull Request resolved: facebook#923 Reviewed By: tmikov Differential Revision: D43630032 Pulled By: neildhar fbshipit-source-id: 5f8cff91a5f01b6507870c61efa1ce507de67940
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks of
As per discussion here: reactwg/react-native-releases#62 (reply in thread)