Replace temp package with vendored code to avoid deprecated rimraf transitive dependency
#618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kitten
changed the title
temp package with vendored codetemp package with vendored code to avoid deprecated rimraf transitive dependency
Daniel15
reviewed
Aug 6, 2024
This wasn't actually used as `temp.track()` wasn't called
kitten
force-pushed
the
@kitten/chore/replace-node-temp
branch
from
5108afb to
68d293a
Compare
|
@Daniel15: Sorry about that! ❤️ There's a test in the latest commit now that checks that the remote transformer files actually work. |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simply to avoid the dependency chain on
rimrafvia[email protected] -> [email protected], which has been deprecated. Thetemppackage hasn't seen a release in a while, and minimal functionality is used from it. Thetemp.trackfunctionality also doesn't seem to be used, which would make it pretty trivial to vendor the code.Switching to alternatives like
tempylikely isn't attractive either since it's ESM-only whilejscodeshiftis not. Older versions oftempyalso depend transitively on deprecated versions ofrimraf.Tests pass and cover changes as-is.
Note: The vendored code has an added copyright notice line for
node-temp.