Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Undo command after creating a Quote removes text after Quote ele… #2767

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Bug: Undo command after creating a Quote removes text after Quote ele… #2767

merged 1 commit into from
Aug 5, 2022

Conversation

iampava
Copy link
Contributor

@iampava iampava commented Aug 5, 2022

…ment (#2750)

@vercel
Copy link

vercel bot commented Aug 5, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Aug 5, 2022 at 9:22AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Aug 5, 2022 at 9:22AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 5, 2022
@iampava
Copy link
Contributor Author

iampava commented Aug 5, 2022 •
edited
Loading

Looks like some tests are failing because of my change. Will have a look at them later today/tomorrow 👀

@fantactuka
Copy link
Contributor

Looks like some tests are failing because of my change. Will have a look at them later today/tomorrow 👀

Looks like it’s all good. Thanks for digging into it!

@thegreatercurve
Copy link
Contributor

Closes #2750

@thegreatercurve
Copy link
Contributor

Thanks @iampava! Much appreciated

@thegreatercurve thegreatercurve merged commit e90eea1 into facebook:main Aug 5, 2022
thegreatercurve pushed a commit that referenced this pull request Nov 25, 2022
@iampava @thegreatercurve
Bug: Undo command after creating a Quote removes text after Quote ele…
b550bcc 
…ment (#2750) (#2767)
@thegreatercurve thegreatercurve mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantactuka fantactuka fantactuka approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iampava @fantactuka @thegreatercurve @facebook-github-bot