bump metro minimum supported Node.js to 18.18 (#1351)

Summary:
After bumping the minimum supported version of Node.js for react native in facebook/react-native-website#4211, this PR bumps the minimum supported version in Metro to 18.8.

This will:
* Align us with React-Native
* Align us with the minimum version of our dev dependencies which comes from `typescript-eslint/typescript-eslint` (also 18.8
  * This will allow us to install `yarn` packages on the minimum version of node without the `--ignore-engines` flag.
* Allow us to get rid of the workaround for fetch in Node.js < 18.14 in `packages/metro/src/integration_tests/__tests__/server-test.js`.

Changelog:**[Breaking]** Bump minimum supported Node.js version to 18.18

Pull Request resolved: #1351

Reviewed By: huntie

Differential Revision: D62505043

Pulled By: vzaidman

fbshipit-source-id: a9d013db36dc203a475770bb5a4dc6e96a64475b

.github/actions/yarn-install/action.yml

@@ -4,10 +4,6 @@ inputs:
     type: string
     required: false
     default: '20.x'
-  ignore-engines:
-    type: string
-    required: false
-    default: 'false'
 
 runs:
   using: "composite"
@@ -19,5 +15,5 @@ runs:
       cache-dependency-path: yarn.lock
       check-latest: true
   - name: Install Dependencies
-    run: yarn install --frozen-lockfile --non-interactive --ignore-scripts ${{ inputs.ignore-engines == 'true' && '--ignore-engines' || ''}}
+    run: yarn install --frozen-lockfile --non-interactive --ignore-scripts
     shell: bash

.github/workflows/build-test-and-deploy.yml

@@ -47,18 +47,11 @@ jobs:
       fail-fast: false
       matrix:
         runs-on: ['ubuntu-latest']
-        node-version: ['18.0', '18.x', '20.x']
-        include:
-          - runs-on: ubuntu-latest
-            node-version: '18.0'
-            # @typescript-eslint/eslint-plugin requires node ^18.18
-            # but we allow yarn install to run regardless to test the package
-            ignore-engines: 'true'
+        node-version: ['18.18', '18.x', '20.x']
     uses: ./.github/workflows/test.yml
     with:
       node-version: ${{ matrix.node-version }}
       runs-on: ${{ matrix.runs-on }}
-      ignore-engines: ${{ matrix.ignore-engines }}
 
   deploy:
     # runs only on tag pushes

.github/workflows/nightly-node-compatibility-validation.yml

@@ -20,17 +20,11 @@ jobs:
       matrix:
         runs-on: ['ubuntu-latest']
         node-version: [  # https://github.com/nodejs/release#release-schedule
-          '18.0',    # minimum supported
+          '18.18',   # minimum supported
           'lts/-1',  # pre-latest lts
           'lts/*',   # latest lts
           'current'  # newest
         ]
-        include:
-          - runs-on: ubuntu-latest
-            node-version: '18.0'
-            # @typescript-eslint/eslint-plugin requires node ^18.18
-            # but we allow yarn install to run regardless to test the package
-            ignore-engines: 'true'
     uses: ./.github/workflows/test.yml
     with:
       node-version: ${{ matrix.node-version }}

.github/workflows/test.yml

@@ -10,10 +10,6 @@ on:
         type: string
         required: false
         default: '20.x'
-      ignore-engines:
-        type: string
-        required: false
-        default: 'false'
 jobs:
   test:
     name: "Tests [Node.js ${{ inputs.node-version }}, ${{ inputs.runs-on }}]"
@@ -23,6 +19,5 @@ jobs:
       - uses: ./.github/actions/yarn-install
         with:
           node-version: ${{ inputs.node-version }}
-          ignore-engines: ${{ inputs.ignore-engines }}
       - name: Run Jest Tests
         run: yarn jest --ci --maxWorkers 4 --reporters=default --reporters=jest-junit --rootdir='./'

package.json

@@ -94,6 +94,6 @@
   "license": "MIT",
   "dependencies": {},
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

packages/buck-worker-tool/package.json

@@ -19,6 +19,6 @@
     "cleanup-release": "test ! -e build && mv src build && mv src.real src"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

packages/metro-babel-register/package.json

@@ -26,6 +26,6 @@
   },
   "license": "MIT",
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

packages/metro-babel-transformer/package.json

@@ -23,6 +23,6 @@
     "nullthrows": "^1.1.1"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

packages/metro-cache-key/package.json

@@ -15,10 +15,10 @@
   "devDependencies": {
     "metro-memory-fs": "0.81.0-alpha.0"
   },
-  "engines": {
-    "node": ">=18"
-  },
   "dependencies": {
     "flow-enums-runtime": "^0.0.6"
+  },
+  "engines": {
+    "node": ">=18.18"
   }
 }

packages/metro-cache/package.json

@@ -21,6 +21,6 @@
   },
   "license": "MIT",
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

packages/metro-config/package.json

@@ -29,6 +29,6 @@
     "strip-ansi": "^6.0.0"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

packages/metro-core/package.json

@@ -18,6 +18,6 @@
   },
   "license": "MIT",
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

packages/metro-file-map/package.json

@@ -32,6 +32,6 @@
     "fsevents": "^2.3.2"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

packages/metro-memory-fs/package.json

@@ -12,10 +12,10 @@
     "cleanup-release": "test ! -e build && mv src build && mv src.real src"
   },
   "license": "MIT",
-  "engines": {
-    "node": ">=18"
-  },
   "dependencies": {
     "flow-enums-runtime": "^0.0.6"
+  },
+  "engines": {
+    "node": ">=18.18"
   }
 }

packages/metro-minify-terser/package.json

@@ -17,6 +17,6 @@
     "terser": "^5.15.0"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

packages/metro-resolver/package.json

@@ -13,7 +13,7 @@
   },
   "license": "MIT",
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   },
   "devDependencies": {
     "metro": "0.81.0-alpha.0"

packages/metro-runtime/package.json

@@ -23,6 +23,6 @@
     "react-test-renderer": "19.0.0-rc-fb9a90fa48-20240614"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

packages/metro-source-map/package.json

@@ -30,6 +30,6 @@
     "terser": "^5.15.0"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

packages/metro-symbolicate/package.json

@@ -26,6 +26,6 @@
     "vlq": "^1.0.0"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

packages/metro-transform-plugins/package.json

@@ -30,6 +30,6 @@
     "metro": "0.81.0-alpha.0"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

packages/metro-transform-worker/package.json

@@ -32,6 +32,6 @@
     "metro-memory-fs": "0.81.0-alpha.0"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

packages/metro/package.json

@@ -73,6 +73,6 @@
   },
   "license": "MIT",
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

packages/metro/src/integration_tests/__tests__/server-test.js

@@ -19,20 +19,11 @@ jest.unmock('cosmiconfig');
 
 jest.setTimeout(60 * 1000);
 
-// Can't set the "Connection" header in node < 18.14.1 (undici < 5.15.0): https://github.com/nodejs/undici/pull/1829,
-// However in these versions "Connection" is set to "close" by default in node 18 anyway comparing with later version
-const [nodeVersionMajor, nodeVersionMinor, nodeVersionPatch] =
-  process.versions.node.split('.').map(Number);
-const canSetConnectionHeader =
-  nodeVersionMajor > 18 ||
-  (nodeVersionMajor === 18 && nodeVersionMinor > 14) ||
-  (nodeVersionMajor === 18 && nodeVersionMinor === 14 && nodeVersionPatch >= 1);
-
 // Workaround for https://github.com/nodejs/node/issues/54484:
-// Fetch with connection: close to prevent Node reusing connections across tests
+// Fetch with {Connection: 'close'} to prevent Node reusing connections across tests
 const fetchAndClose = (path: string) =>
   fetch(path, {
-    headers: canSetConnectionHeader ? {Connection: 'close'} : {},
+    headers: {Connection: 'close'},
   });
 
 describe('Metro development server serves bundles via HTTP', () => {

packages/ob1/package.json

@@ -19,6 +19,6 @@
     "flow-enums-runtime": "^0.0.6"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }