Remove runInspectorProxy option

Summary:
In preparation to relocate `metro-inspector-proxy` into the React Native repo, this PR removes the `runInspectorProxy` option from Metro's server, as a config option, and as a dependency of the `metro` package. This is a breaking change, where we now intend for dev servers that wrap Metro to mount this WebSocket middleware externally.

The `runInspectorProxy` option is unused today by RN CLI, Expo CLI, `rnx-kit`.

Changelog: **[Breaking]** Remove `runInspectorProxy` option from server

Reviewed By: motiz88

Differential Revision: D48066221

fbshipit-source-id: ce12ddbc1420bab9ddf47b1232433c1bc671c590

docs/Configuration.md

@@ -631,12 +631,6 @@ Type: `string => string`
 
 A function that will be called every time Metro processes a URL, after normalization of non-standard query-string delimiters using [`jsc-safe-url`](https://www.npmjs.com/package/jsc-safe-url). Metro will use the return value of this function as if it were the original URL provided by the client. This applies to all incoming HTTP requests (after any custom middleware), as well as bundle URLs in `/symbolicate` request payloads and within the hot reloading protocol.
 
-#### `runInspectorProxy`
-
-Type: `boolean` (default: `true`)
-
-Run Inspector Proxy server inside Metro to be able to inspect React Native code.
-
 ---
 
 ### Watcher Options

packages/metro-config/src/__tests__/__snapshots__/loadConfig-test.js.snap

@@ -101,7 +101,6 @@ Object {
     "enhanceMiddleware": [Function],
     "port": 8081,
     "rewriteRequestUrl": [Function],
-    "runInspectorProxy": true,
     "unstable_serverRoot": null,
     "useGlobalHotkey": true,
     "verifyConnections": false,
@@ -279,7 +278,6 @@ Object {
     "enhanceMiddleware": [Function],
     "port": 8081,
     "rewriteRequestUrl": [Function],
-    "runInspectorProxy": true,
     "unstable_serverRoot": null,
     "useGlobalHotkey": true,
     "verifyConnections": false,
@@ -457,7 +455,6 @@ Object {
     "enhanceMiddleware": [Function],
     "port": 8081,
     "rewriteRequestUrl": [Function],
-    "runInspectorProxy": true,
     "unstable_serverRoot": null,
     "useGlobalHotkey": true,
     "verifyConnections": false,
@@ -635,7 +632,6 @@ Object {
     "enhanceMiddleware": [Function],
     "port": 8081,
     "rewriteRequestUrl": [Function],
-    "runInspectorProxy": true,
     "unstable_serverRoot": null,
     "useGlobalHotkey": true,
     "verifyConnections": false,

packages/metro-config/src/configTypes.flow.js

@@ -168,7 +168,6 @@ type ServerConfigT = {
   enhanceMiddleware: (Middleware, MetroServer) => Middleware | Server,
   port: number,
   rewriteRequestUrl: string => string,
-  runInspectorProxy: boolean,
   unstable_serverRoot: ?string,
   useGlobalHotkey: boolean,
   verifyConnections: boolean,
@@ -262,7 +261,6 @@ export type YargArguments = $ReadOnly<{
   transformer?: string,
   'reset-cache'?: boolean,
   resetCache?: boolean,
-  runInspectorProxy?: boolean,
   verbose?: boolean,
   ...
 }>;

packages/metro-config/src/defaults/index.js

@@ -76,7 +76,6 @@ const getDefaultValues = (projectRoot: ?string): ConfigT => ({
     enhanceMiddleware: (middleware, _) => middleware,
     port: 8081,
     rewriteRequestUrl: url => url,
-    runInspectorProxy: true,
     unstable_serverRoot: null,
     useGlobalHotkey: true,
     verifyConnections: false,

packages/metro-config/src/loadConfig.js

@@ -234,12 +234,6 @@ function overrideConfigWithArguments(
     output.server.port = Number(argv.port);
   }
 
-  if (argv.runInspectorProxy != null) {
-    // $FlowFixMe[incompatible-use]
-    // $FlowFixMe[cannot-write]
-    output.server.runInspectorProxy = Boolean(argv.runInspectorProxy);
-  }
-
   if (argv.projectRoot != null) {
     output.projectRoot = argv.projectRoot;
   }

packages/metro-config/types/configTypes.d.ts

@@ -166,7 +166,6 @@ export interface ServerConfigT {
   ) => Middleware | Server;
   port: number;
   rewriteRequestUrl: (url: string) => string;
-  runInspectorProxy: boolean;
   unstable_serverRoot: string | null;
   useGlobalHotkey: boolean;
   verifyConnections: boolean;
@@ -251,6 +250,5 @@ export interface YargArguments {
   transformer?: string;
   'reset-cache'?: boolean;
   resetCache?: boolean;
-  runInspectorProxy?: boolean;
   verbose?: boolean;
 }

packages/metro/package.json

@@ -41,7 +41,6 @@
     "metro-config": "0.77.0",
     "metro-core": "0.77.0",
     "metro-file-map": "0.77.0",
-    "metro-inspector-proxy": "0.77.0",
     "metro-minify-terser": "0.77.0",
     "metro-resolver": "0.77.0",
     "metro-runtime": "0.77.0",

packages/metro/src/index.flow.js

@@ -47,7 +47,6 @@ const {
   resolveConfig,
 } = require('metro-config');
 const {Terminal} = require('metro-core');
-const {InspectorProxy} = require('metro-inspector-proxy');
 const net = require('net');
 const {parse} = require('url');
 
@@ -68,7 +67,6 @@ export type RunServerOptions = $ReadOnly<{
   host?: string,
   onError?: (Error & {code?: string}) => void,
   onReady?: (server: HttpServer | HttpsServer) => void,
-  runInspectorProxy?: boolean,
   secureServerOptions?: Object,
   secure?: boolean, // deprecated
   secureCert?: string, // deprecated
@@ -281,11 +279,6 @@ exports.runServer = async (
     serverApp.use(handler);
   }
 
-  let inspectorProxy: ?InspectorProxy = null;
-  if (config.server.runInspectorProxy) {
-    inspectorProxy = new InspectorProxy(config.projectRoot);
-  }
-
   let httpServer;
 
   if (secure || secureServerOptions != null) {
@@ -322,9 +315,6 @@ exports.runServer = async (
 
         websocketEndpoints = {
           ...websocketEndpoints,
-          ...(inspectorProxy
-            ? {...inspectorProxy.createWebSocketListeners(httpServer)}
-            : {}),
           '/hot': createWebsocketServer({
             websocketServer: new MetroHmrServer(
               metroServer.getBundler(),
@@ -350,14 +340,6 @@ exports.runServer = async (
           }
         });
 
-        if (inspectorProxy) {
-          // TODO(hypuk): Refactor inspectorProxy.processRequest into separate request handlers
-          // so that we could provide routes (/json/list and /json/version) here.
-          // Currently this causes Metro to give warning about T31407894.
-          // $FlowFixMe[method-unbinding] added when improving typing for this parameters
-          serverApp.use(inspectorProxy.processRequest.bind(inspectorProxy));
-        }
-
         resolve(httpServer);
       });
 

packages/metro/types/index.d.ts

@@ -62,7 +62,6 @@ export interface RunServerOptions {
   host?: string;
   onError?: (error: Error & {code?: string}) => void;
   onReady?: (server: HttpServer | HttpsServer) => void;
-  runInspectorProxy?: boolean;
   secureServerOptions?: Record<string, unknown>;
 
   /** @deprecated since version 0.61 */