-
Notifications
You must be signed in to change notification settings - Fork 637
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use
FileSystem
instance for crawl previous state instead of raw `Fi…
…leData` Summary: - Add a `getDifference` method to `FileSystem` to return a `{changedFiles: FileData, removedFiles: Set<string>}` given a `FileData` representing the complete *current* set of files in the system, treating the `FileSystem` instance as base state. - Pass a `FileSystem` to crawler backends so that they may use `getDifference` instead of directly comparing with the raw deserialised `files` map. This consolidates some diffing logic previously repeated in crawler backends, and allows us to make the data structure for `files` an implementation detail of `FileSystem` - in particular, we want to avoid maintaining both a flat map and a prefix tree in `TreeFS`. Changelog: Internal Reviewed By: huntie Differential Revision: D46515321 fbshipit-source-id: 1cbbaca4a83e92af42ee4c52b77ad13de3655eec
- Loading branch information
1 parent
42854be
commit d376529
Showing
10 changed files
with
132 additions
and
108 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.