Fix EPERM errors reading transient/locked files on Windows without Watchman #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tchman Summary: As reported in facebook#1001, `fs.lstat` operations on Windows can fail with `EPERM` in certain circumstances - apparently when new files are either still being written or are about to be deleted. Currently, this bubbles up as a Watcher error, whereas it should be handled gracefully. Reportedly the OS will follow up with another event on the file when it's ready to read, so we may safely ignore `EPERM` in `add`/`change` event processing. NOTE: This raises the question of why we're watching build output/intermediate directories in the default React Native Metro config. We should almost certainly be ignoring them from Metro. ``` - **[Changelog]** Fix EPERM file watching errors on Windows. ``` Differential Revision: D46803761 fbshipit-source-id: e9551392208240e91ab813487efb94849f7e41b8
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46803761 |
|
This pull request has been merged in 4b22efb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As reported in #1001,
fs.lstatoperations on Windows can fail withEPERMin certain circumstances - apparently when new files are either still being written or are about to be deleted.Currently, this bubbles up as a Watcher error, whereas it should be handled gracefully.
Reportedly the OS will follow up with another event on the file when it's ready to read, so we may safely ignore
EPERMinadd/changeevent processing.NOTE: This raises the question of why we're watching build output/intermediate directories in the default React Native Metro config. We should almost certainly be ignoring them from Metro.
Differential Revision: D46803761