Widen config search paths to include metro.config.cjs #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Resolves facebook#1026, resolves facebook#916. Changelog: **[Feature]** Widen config search paths to include `metro.config.cjs` Differential Revision: D47290079 fbshipit-source-id: d50c61f08580a04ad2de57092a0c77c5c5b0f22a
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47290079 |
oblador
reviewed
Jul 7, 2023
|
Thanks for a quick fix!
Are you sure this is true? Doesn't seem to address TS in the config |
|
This pull request has been merged in 6922933. |
huntie
added a commit
to huntie/metro
that referenced
this pull request
Aug 7, 2023
Summary: Pull Request resolved: facebook#1027 Resolves facebook#1026. Changelog: **[Feature]** Widen config search paths to include `metro.config.cjs` Reviewed By: robhogan Differential Revision: D47290079 fbshipit-source-id: 3e46c954a1e1451558b14ed4558fede5f00200dd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Resolves #1026.
Changelog: [Feature] Widen config search paths to include
metro.config.cjsDifferential Revision: D47290079