Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metro] add $FlowExpectedError annotation for optional visualizer dep #278

Closed
wants to merge 1 commit into from

Conversation

Salakar
Copy link
Contributor

@Salakar Salakar commented Oct 2, 2018

This adds a $FlowExpectedError comment annotation for the optional metro-visualizer dependency, resolves the following issue:

image

Summary

Test plan

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2018
@codecov-io
Copy link

Codecov Report

Merging #278 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files         144      144           
  Lines        4548     4548           
  Branches      712      712           
=======================================
  Hits         3900     3900           
  Misses        580      580           
  Partials       68       68
Impacted Files Coverage Δ
packages/metro/src/index.js 74.69% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a62c79...044d1e4. Read the comment docs.

Copy link
Contributor

@rafeca rafeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! it's strange that this is failing in the React Native repo but not in the Metro repo...

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rafeca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Salakar
Copy link
Contributor Author

Salakar commented Oct 2, 2018

It is strange, there was a dev dependency but removing that locally made no difference, I had to physically delete the metro-visuallizer directory in packages/ locally to be able to reproduce the error - so must be a yarn workspaces thing, one to note for future I guess 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants