Add custom serializer #309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
=========================================
- Coverage 86.31% 86.3% -0.01%
=========================================
Files 163 163
Lines 4916 4908 -8
Branches 753 752 -1
=========================================
- Hits 4243 4236 -7
+ Misses 600 599 -1
Partials 73 73
Continue to review full report at Codecov.
|
mjesun
suggested changes
Nov 8, 2018
mjesun
approved these changes
Nov 8, 2018
There was a problem hiding this comment.
@mjesun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
thymikee
added a commit
to thymikee/metro
that referenced
this pull request
Mar 3, 2019
…ation * upstream/master: (42 commits) Bump [email protected] Fix entryFile always is assumed to end with `.js` extension (facebook#310) Adds support for `publicPath` to enable serving assets from different locations. (facebook#299) Make dynamic import interoperable for CJS and ESM Add custom serializer (facebook#309) React sync for revisions 4773fdf...3ff2c7c metro-buck: disable inline IDs in dev mode Simplify helper function Rewrite traverseDependency-integration-tests to make them module resolution unit tests RN: Revert React 16.6 Sync React sync for revisions 4773fdf...bf9fadf Bump react-deep-force-update Use getFileIterator() from jest-haste-map Deploy Flow v0.85 to xplat/js metro-buck: add explicit import() prefetch feature jest: remove jasmine usages jest: upgrade to 24.0.0-alpha.4 Fix source map loading in the remote debugger Fix metro visualizer transformation Update babel to version 7 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We would like to bundle an entryfile differently than it is currently done in Metro, specifically in development. Without a pluggable serializer, we wouldn't be able to perform bundle splitting in development, which is impactful to our development speed.
This PR alleviates bundle sizing problem by introducing a customSerializer instead of using the
plainJSBundle.Some minor question, do I have to implement this in the
buildpublic method in the server?Test plan
customSerializerand test it against the new change in metro. Our bundle was able to do what we needed it to accomplish.