Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sourceMapURL when building bundles for windows/macOS #763

Closed
wants to merge 3 commits into from
Closed

Fix sourceMapURL when building bundles for windows/macOS #763

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f92ba73
Fix sourceMapURL when building bundles for windows/macOS
acoates-ms Jan 25, 2022
798af86
prettier fix
acoates-ms Jan 25, 2022
d0253a8
Merge branch 'main' into windowsSourcemapurl
acoates-ms Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/metro/src/lib/parseOptionsFromUrl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ module.exports = function parseOptionsFromUrl(
// when loading the bundle for either Android or iOS.
// TODO(T167298674): Remove when remote debugging is not needed in React Native
protocol:
platform != null && platform.match(/^(android|ios|vr)$/) ? 'http' : '',
platform != null && platform.match(/^(android|ios|vr|windows|macos)$/)
? 'http'
: '',
pathname: pathname.replace(/\.(bundle|delta)$/, '.map'),
}),
sourceUrl: jscSafeUrl.toJscSafeUrl(normalizedRequestUrl),
Expand Down