Echoserver does not use folly::EventBase #67
Comments
|
The EchoServer uses EVB to do one thing: to loop forever: https://github.com/facebookincubator/mvfst/blob/master/quic/samples/echo/EchoServer.h#L86 The QuicServer creates evbs used by Quic transports internally: https://github.com/facebookincubator/mvfst/blob/master/quic/server/QuicServer.cpp#L89 |
facebook-github-bot
pushed a commit
that referenced
this issue
Oct 16, 2020
…ps.py build (#67) Summary: Pull Request resolved: facebook/sapling#67 With this change it will be possible to build dependencies of and run integration tests using getdeps.py. This is the first goal of Q4 as per https://fb.quip.com/v8YzAYNSYgot: "Get Open Source version of integration tests running on Legocastle". Before this diff: The OSS integration tests run now on GitHub by: - Building some test dependencies with getdeps.py - Building some test dependencies with homebrew/apt-get - Running tests via python script The OSS integration tests were not running on Sandcastle. After this diff: The OSS integration tests run on Github by: - Building and executing tests via getdeps.py (execution of tests happens by getdeps.py calling Make calling python script) The OSS integration tests run on Sandcastle using the same getdeps.py setup as Github. Reviewed By: krallin Differential Revision: D24253268 fbshipit-source-id: cae249b72d076222673b8bbe4ec21866dcdbb253
facebook-github-bot
pushed a commit
that referenced
this issue
Mar 3, 2022
Summary: X-link: facebookincubator/hsthrift#67 Updating `googletest` from `1.8.0` to `1.10.0` Reviewed By: mzlee, igorsugak, luciang, meyering, r-barnes Differential Revision: D34351084 fbshipit-source-id: 939b3985ab63a06b6d511ec8711c2d5863bdfea8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The example echo server in Echoserver does not require folly::EventBase.
You can hang the server with a simple
while(1) usleep(1000000);Though one could do better of course.
I imagine folly::EventBase is left over from a very early implementation
The text was updated successfully, but these errors were encountered: