Add QuicPskCache to FizzClientQuicHandshakeContext #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
deadalnix
force-pushed
the
fizzcontextpskcache
branch
from
bde83b2 to
ce57445
Compare
There was a problem hiding this comment.
@mjoras has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
deadalnix
force-pushed
the
fizzcontextpskcache
branch
from
ce57445 to
1d73fd1
Compare
There was a problem hiding this comment.
@mjoras has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mjoras
requested changes
Mar 12, 2020
| explicit FakeOneRttHandshakeLayer(QuicClientConnectionState* conn) | ||
| explicit FakeOneRttHandshakeLayer( | ||
| QuicClientConnectionState* conn, | ||
| std::shared_ptr<FizzClientQuicHandshakeContext> fizzContext) |
There was a problem hiding this comment.
This has an unused param warning which ends up being a compiler error internally
There was a problem hiding this comment.
Ok will fix. I plan to use it down the road, but I can introduce it then rather than now.
deadalnix
force-pushed
the
fizzcontextpskcache
branch
from
1d73fd1 to
ccf8f08
Compare
There was a problem hiding this comment.
@mjoras has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 8, 2022
Summary: Pull Request resolved: facebook/sapling#103 Automate maintenance of the edenscm_* github actions yamls Add job file and name options and support for the Rust install section Reviewed By: fanzeyi Differential Revision: D34044422 fbshipit-source-id: 7d5f07d37bab1eff5de30a88e710dbf7479ca192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step toward moving the psk cache handling in the handshake rather than the transport layer.