A few adjustments for MSVC #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first is to use `FOLLY_TLS` rather than `__thread`. The second is to not try to ignore some signals, because those signals don't exist under MSVC. The final change is to switch `parseHTTPDateTime` to use the standard C++ function `std::get_time` rather than the posix function `strptime` to parse the times. This is because `strptime` is not available under MSVC. The format parameter of `std::get_time` is [defined](http://en.cppreference.com/w/cpp/io/manip/get_time) to be the same as `strptime`.
|
Can you please update the patch with one of your suggestions, preferably the second one? |
|
Moved internally to D2898241. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 16, 2020
…ps.py build (#67) Summary: Pull Request resolved: facebook/sapling#67 With this change it will be possible to build dependencies of and run integration tests using getdeps.py. This is the first goal of Q4 as per https://fb.quip.com/v8YzAYNSYgot: "Get Open Source version of integration tests running on Legocastle". Before this diff: The OSS integration tests run now on GitHub by: - Building some test dependencies with getdeps.py - Building some test dependencies with homebrew/apt-get - Running tests via python script The OSS integration tests were not running on Sandcastle. After this diff: The OSS integration tests run on Github by: - Building and executing tests via getdeps.py (execution of tests happens by getdeps.py calling Make calling python script) The OSS integration tests run on Sandcastle using the same getdeps.py setup as Github. Reviewed By: krallin Differential Revision: D24253268 fbshipit-source-id: cae249b72d076222673b8bbe4ec21866dcdbb253
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 3, 2022
Summary: X-link: facebookincubator/hsthrift#67 Updating `googletest` from `1.8.0` to `1.10.0` Reviewed By: mzlee, igorsugak, luciang, meyering, r-barnes Differential Revision: D34351084 fbshipit-source-id: 939b3985ab63a06b6d511ec8711c2d5863bdfea8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first is to use
FOLLY_TLSrather than__thread.The second is to not try to ignore some signals, because those signals don't exist under MSVC.
The final change is to switch
parseHTTPDateTimeto use the standard C++ functionstd::get_timerather than the posix functionstrptimeto parse the times. This is becausestrptimeis not available under MSVC. The format parameter ofstd::get_timeis defined to be the same asstrptime.