Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt OpenJDK11 #2800

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Adopt OpenJDK11 #2800

merged 3 commits into from
Jan 19, 2022

Conversation

svbutko
Copy link
Contributor

@svbutko svbutko commented Oct 3, 2021

Based on Gradle version upgrade it will be needed to install JDK 11:
facebook/react-native#32186

@netlify
Copy link

netlify bot commented Oct 3, 2021

✔️ Deploy Preview for react-native ready!

🔨 Explore the source changes: 29b5a04

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/61e803743420970007dfcff0

😎 Browse the preview: https://deploy-preview-2800--react-native.netlify.app

@Simek Simek added the 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged label Oct 3, 2021
@cortinico
Copy link
Contributor

@svbutko Can I ask you to rebase as this I believe is ready to land 👍

@Simek
Copy link
Collaborator

Simek commented Jan 12, 2022

The change has landed only on main, so we need to wait for the 0.67 cut to happen, to merge this PR in.

@Simek Simek added Wait on future Release This indicates a PR that updates the doc to match a future release. and removed 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged labels Jan 12, 2022
@cortinico
Copy link
Contributor

The change has landed only on main, so we need to wait for the 0.67 cut to happen, to merge this PR in.

This change is backward compatible though. You can use JDK 11 to build previous version of RN without problems. With the upcoming version instead, it will become a requirement.

@kelset
Copy link
Contributor

kelset commented Jan 19, 2022

 @Simek I think you meant to say 0.68?

@Simek
Copy link
Collaborator

Simek commented Jan 19, 2022

Not exactly, I should write that we need to wait for the 0.67 docs cut merge, not only the cut. :)

If we merge this now, for a while, the change will appear in next docs, which will be incorrect, but after the merge of 0.67 cut the next version will represent the state of 0.68.

@kelset
Copy link
Contributor

kelset commented Jan 19, 2022

gotcha: so version 0.67 of react-native is not affected by this, so this PR can only be merged after this PR is merged: #2926

correct?

@cortinico
Copy link
Contributor

If we merge this now, for a while, the change will appear in next docs, which will be incorrect, but after the merge of 0.67 cut the next version will represent the state of 0.68.

Just to clarify: this specific change is making JDK 11 the "suggested" JDK versions.
It necessarily needs to be in the 0.68 docs, as there it will be come a hard requirement. It won't hurt to have it inside the 0.67 docs as well as JDK versions are backwards compatibles.

@Simek
Copy link
Collaborator

Simek commented Jan 19, 2022

@cortinico Thanks for the clarification! So we can merge it now, right?

@cortinico
Copy link
Contributor

So we can merge it now, right?

Essentially yes 👍

@Simek Simek marked this pull request as ready for review January 19, 2022 12:32
@Simek Simek merged commit 7b6b71e into facebook:main Jan 19, 2022
@Simek
Copy link
Collaborator

Simek commented Jan 19, 2022

To see this change in the 0.67 docs we need to cherry pick this commit into 0.67 docs cut or just sync the cut branch with main. CC @kelset

@kelset
Copy link
Contributor

kelset commented Jan 19, 2022

ok, let me rebase my branch on top of main for good measure and re-gen the docs

@kelset
Copy link
Contributor

kelset commented Jan 19, 2022

(done: #2926 (comment) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Wait on future Release This indicates a PR that updates the doc to match a future release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants