-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt OpenJDK11 #2800
Adopt OpenJDK11 #2800
Conversation
✔️ Deploy Preview for react-native ready! 🔨 Explore the source changes: 29b5a04 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/61e803743420970007dfcff0 😎 Browse the preview: https://deploy-preview-2800--react-native.netlify.app |
@svbutko Can I ask you to rebase as this I believe is ready to land 👍 |
The change has landed only on |
This change is backward compatible though. You can use JDK 11 to build previous version of RN without problems. With the upcoming version instead, it will become a requirement. |
@Simek I think you meant to say 0.68? |
Not exactly, I should write that we need to wait for the 0.67 docs cut merge, not only the cut. :) If we merge this now, for a while, the change will appear in |
gotcha: so version 0.67 of react-native is not affected by this, so this PR can only be merged after this PR is merged: #2926 correct? |
Just to clarify: this specific change is making JDK 11 the "suggested" JDK versions. |
@cortinico Thanks for the clarification! So we can merge it now, right? |
Essentially yes 👍 |
To see this change in the |
ok, let me rebase my branch on top of main for good measure and re-gen the docs |
(done: #2926 (comment) ) |
Based on Gradle version upgrade it will be needed to install JDK 11:
facebook/react-native#32186