Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Linting/Typechecking to RN 0.72 #3647

Merged
merged 3 commits into from
May 8, 2023
Merged

Bump Linting/Typechecking to RN 0.72 #3647

merged 3 commits into from
May 8, 2023

Conversation

NickGerleman
Copy link
Contributor

@NickGerleman NickGerleman commented Mar 24, 2023 •
edited
Loading

This bumps the types and other packages used during linting to match RN 0.72. This ensures the current docs are compatible with 0.72 before we cut a version.

@netlify
Copy link

netlify bot commented Mar 24, 2023 •
edited
Loading

❌ Deploy Preview for react-native failed.

Name Link
🔨 Latest commit 3883d90
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/6458ebadfbab190008cee348

@NickGerleman NickGerleman changed the title WIP Bump Types Bump Linting/Typechecking to RN 0.72 Mar 24, 2023
@NickGerleman
Copy link
Contributor Author

We are still missing:

  1. Updating examples to not rely on Slider
  2. Fix for EmitterSubscription being removed Export EmitterSubscription TypeScript Type react-native#36632

@NickGerleman NickGerleman marked this pull request as ready for review May 8, 2023 12:27
@NickGerleman
Copy link
Contributor Author

Updated with a new RC revision (new typings), and rebased to after the Slider usage was removed.

@NickGerleman NickGerleman reopened this May 8, 2023
Simek
Simek approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@NickGerleman
Copy link
Contributor Author

Netlify deploy failed due to some issue downloading Node. Manually validated yarn build passes instead.

@NickGerleman NickGerleman merged commit 0bd61f4 into facebook:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

@Simek Simek Simek approved these changes

Assignees
No one assigned
Labels
CLA Signed p: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NickGerleman @Simek @rickhanlonii @facebook-github-bot