Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added platform label annotation of onAccessibilityTap prop #4345

Conversation

princektripathi
Copy link
Contributor

@princektripathi princektripathi commented Nov 7, 2024

What did I change?
I added a platform label for the onAccessibilityTap prop on the React Native documentation page.

Why did I change it?
An issue was reported regarding onAccessibilityTap not working on Android, but this prop is only intended for the iOS platform. This change will help clarify platform-specific behaviour and prevent future confusion among users.

Reported issue - facebook/react-native#47149
Action item - facebook/react-native#47149 (comment)

@facebook-github-bot
Copy link

Hi @princektripathi!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@princektripathi princektripathi changed the title fix: platform label annotation of onAccessibilityTap prop fix: added platform label annotation of onAccessibilityTap prop Nov 7, 2024
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 3ed8bca
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/672cb35d29aaa600086dd572
😎 Deploy Preview https://deploy-preview-4345--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@princektripathi
Copy link
Contributor Author

princektripathi commented Nov 7, 2024

@cipolleschi, @Simek, could you please verify this change? It will help to avoid further confusion among users.

@princektripathi
Copy link
Contributor Author

@cortinico , could you please merge this PR as per your convenience?

@cortinico cortinico merged commit 2bd5f43 into facebook:main Nov 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants