Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Docusaurus native CSS transitions #4377

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Dec 1, 2024

Remove restrictions on CSS transitions to allow for native transitions in Docusaurus components.

this brings back things like:

  • sidebar menu transition in and out of view
  • sidebar menu list expand and collapse animation
  • link and button hover animation
  • popover in and out animation
Screen.Recording.2024-12-01.at.11.05.31.AM.mp4

closes #4379

Copy link

netlify bot commented Dec 1, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 14996f5
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/674c326a4008e90008f13a4b
😎 Deploy Preview https://deploy-preview-4377--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I'm wondering why they were disabled in the first place

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you for those changes! 👍


TL/DR: The React Native website was a test ground for Docusaurus v2 before its stable release, and IIRC we have some issue with animations at that time. But this was a long time ago, and I guess we forgot to test, and re-enable the animations with further upgrades:

@Simek Simek merged commit 165b904 into facebook:main Dec 2, 2024
4 checks passed
@hichemfantar hichemfantar deleted the css-transitions branch December 2, 2024 12:36
@hichemfantar
Copy link
Contributor Author

glad you liked the changes!

if i can get your attention to a couple of PRs i made that greatly enhance the DX #4381 and #4375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing docusaurus animations
4 participants