Skip to content

Commit

Permalink
[LOCAL][RN][CI] Fix Build Slice Job for VisionOS
Browse files Browse the repository at this point in the history
  • Loading branch information
cipolleschi committed Jul 22, 2024
1 parent 713b6b9 commit 3597552
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 1 addition & 5 deletions .circleci/configurations/jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -786,9 +786,9 @@ jobs:
- HERMES_WS_DIR: *hermes_workspace_root
- HERMES_TARBALL_ARTIFACTS_DIR: *hermes_tarball_artifacts_dir
- HERMES_OSXBIN_ARTIFACTS_DIR: *hermes_osxbin_artifacts_dir
- IPHONEOS_DEPLOYMENT_TARGET: "13.4"
- XROS_DEPLOYMENT_TARGET: "1.0"
- MACOSX_DEPLOYMENT_TARGET: "10.15"
- IPHONEOS_DEPLOYMENT_TARGET: "13.4"
steps:
- *attach_hermes_workspace
- stop_job_if_apple_artifacts_are_there:
Expand Down Expand Up @@ -819,14 +819,10 @@ jobs:
export RELEASE_VERSION=$(cat /tmp/react-native-version)
if [[ "$SLICE" == "macosx" ]]; then
echo "[HERMES] Building Hermes for MacOS"
export MAC_DEPLOYMENT_TARGET=10.13
BUILD_TYPE="<< parameters.flavor >>" ./utils/build-mac-framework.sh
unset MAC_DEPLOYMENT_TARGET
else
echo "[HERMES] Building Hermes for iOS: $SLICE"
export IOS_DEPLOYMENT_TARGET=13.4
BUILD_TYPE="<< parameters.flavor >>" ./utils/build-ios-framework.sh "$SLICE"
unset IOS_DEPLOYMENT_TARGET
fi
unset RELEASE_VERSION
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,10 @@ function get_architecture {
function get_deployment_target {
if [[ $1 == "xros" || $1 == "xrsimulator" ]]; then
echo "$(get_visionos_deployment_target)"
return
else
echo "$(get_ios_deployment_target)"
return
fi
}

Expand Down

0 comments on commit 3597552

Please sign in to comment.