Skip to content

Commit

Permalink
Revert D57681447: Expose DevSettings.openDebugger method to JS
Browse files Browse the repository at this point in the history
Differential Revision:
D57681447

Original commit changeset: ddb1fbd0f1c8

Original Phabricator Diff: D57681447

fbshipit-source-id: 94bf94227bcc9fab8282bd68ddf3f4f1df64656b
  • Loading branch information
rybalkinsd authored and facebook-github-bot committed Jun 13, 2024
1 parent 7e0f894 commit 726a4a1
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 17 deletions.
12 changes: 0 additions & 12 deletions packages/react-native/React/CoreModules/RCTDevSettings.mm
Original file line number Diff line number Diff line change
Expand Up @@ -501,15 +501,6 @@ - (void)setupHMRClientWithAdditionalBundleURL:(NSURL *)bundleURL
}
}

RCT_EXPORT_METHOD(openDebugger)
{
#if RCT_ENABLE_INSPECTOR
[RCTInspectorDevServerHelper
openDebugger:self.bundleManager.bundleURL
withErrorMessage:@"Failed to open debugger. Please check that the dev server is running and reload the app."];
#endif
}

#pragma mark - Internal

/**
Expand Down Expand Up @@ -617,9 +608,6 @@ - (void)setupHMRClientWithBundleURL:(NSURL *)bundleURL
- (void)setupHMRClientWithAdditionalBundleURL:(NSURL *)bundleURL
{
}
- (void)openDebugger
{
}
- (void)addMenuItem:(NSString *)title
{
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,6 @@ public class DevSettingsModule(
}
}

override fun openDebugger() {
devSupportManager.openDebugger()
}

override fun setIsShakeToShowDevMenuEnabled(enabled: Boolean) {
// iOS only
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export interface Spec extends TurboModule {
+setProfilingEnabled: (isProfilingEnabled: boolean) => void;
+toggleElementInspector: () => void;
+addMenuItem: (title: string) => void;
+openDebugger?: () => void;

// Events
+addListener: (eventName: string) => void;
Expand Down

0 comments on commit 726a4a1

Please sign in to comment.